Skip to content

Commit

Permalink
fix(bundler): warning for self contained updaters (#10270)
Browse files Browse the repository at this point in the history
* Fix warning for self contained updaters

* Add change file
  • Loading branch information
Legend-Master authored Jul 15, 2024
1 parent 506f1dd commit d1df6be
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/fix-updater-warning.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
tauri-bundler: patch:bug
---

Fix bundler warns about no updater-enabled targets were built for self contained updaters like app image, nsis, msi
10 changes: 9 additions & 1 deletion tooling/bundler/src/bundle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,15 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<Bundle>> {
package_type: PackageType::Updater,
bundle_paths: updater_paths,
});
} else {
} else if updater.v1_compatible
|| !package_types.iter().any(|package_type| {
// Self contained updater, no need to zip
matches!(
package_type,
PackageType::AppImage | PackageType::Nsis | PackageType::WindowsMsi
)
})
{
log::warn!("The bundler was configured to create updater artifacts but no updater-enabled targets were built. Please enable one of these targets: app, appimage, msi, nsis");
}
if updater.v1_compatible {
Expand Down

0 comments on commit d1df6be

Please sign in to comment.