Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): adb port forward error handling, add logs, closes #9509 #10604

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

lucasfernog
Copy link
Member

a port can only be forward to a single device connected with adb, so we must handle:

  • multiple devices connected
  • port already forwarded to another device

this change also includes better error handling and logs so it's easier for us to triage issues

a port can only be forward to a single device connected with adb, so we must handle:
- multiple devices connected
- port already forwarded to another device

this change also includes better error handling and logs so it's easier for us to triage issues
@lucasfernog lucasfernog requested a review from a team as a code owner August 14, 2024 00:44
Copy link
Contributor

Package Changes Through 2f584e6

There are 7 changes which include tauri-build with prepatch, tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri-codegen with prerelease, tauri-utils with prerelease, tauri-bundler with prerelease, tauri with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0-rc.2 2.0.0-rc.3
tauri-bundler 2.0.1-rc.1 2.0.1-rc.2
tauri-runtime 2.0.0-rc.2 2.0.0-rc.3
tauri-runtime-wry 2.0.0-rc.2 2.0.0-rc.3
tauri-codegen 2.0.0-rc.2 2.0.0-rc.3
tauri-macros 2.0.0-rc.2 2.0.0-rc.3
tauri-plugin 2.0.0-rc.2 2.0.0-rc.3
tauri-build 2.0.0-rc.2 2.0.1-rc.0
tauri 2.0.0-rc.2 2.0.0-rc.3
@tauri-apps/cli 2.0.0-rc.3 2.0.0-rc.4
tauri-cli 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit 9f75d06 into dev Aug 14, 2024
15 checks passed
@lucasfernog lucasfernog deleted the fix/adb-forward branch August 14, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants