feat: Custom sign command with object notation #10634
Conversation
Package Changes Through e520696There are 6 changes which include tauri with prerelease, tauri-build with prerelease, tauri-utils with prerelease, tauri-bundler with prerelease, @tauri-apps/cli with prerelease, tauri-cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I ran cargo fmt at repository root again but no diff are generated. I feel it's weird to fail fmt check |
| "tauri-utils": patch:breaking | ||
| --- | ||
|
|
||
| Custom sign command for windows executables is now with object instead of string to support whitespaces in the command path and arguments. |
There was a problem hiding this comment.
I wonder if it is worth supporting both formats, string is more concise for simple use cases and object is better for white space paths and such
There was a problem hiding this comment.
supporting both formats is what we do :) use an enum with serde(untagged)
There was a problem hiding this comment.
@anatawa12 sorry for the inconvenience, could you add support for both? and add a note in docs that users should use the object format if their binary or arguments have spaces.
There was a problem hiding this comment.
OK.
Should support quote in string notation for whitespaces? or use old simple parser with split(' ')?
There was a problem hiding this comment.
use old simple parser, and just add a note in docs, thanks
There was a problem hiding this comment.
I added string form support in 53e285a.
Since string format is only for simpler config file, I added parsing logic in cli module and bundler module have single object form as input.
anatawa12
force-pushed
the
object-notation-for-custom-sign-command
branch
from
cc88888
to
d01d92f
Compare
I found that I have to run |
anatawa12
changed the title
#10589 (comment)