refactor(cli): synchronize pbxproj and export options, handle cert on build #10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucasfernog
commented
Aug 18, 2024
lucasfernog
commented
- adds a pbxproj parser and writer (very simple, just for the objects we actually need)
- changed codesign modifications from ios init to ios build
- synchronize pbxproj with export options so that CLI build works if you change the xcode project manually
- adds a pbxproj parser and writer (very simple, just for the objects we actually need) - changed codesign modifications from ios init to ios build - synchronize pbxproj with export options so that CLI build works if you change the xcode project manually
Package Changes Through 155182bThere are 3 changes which include tauri-utils with prerelease, tauri-cli with prerelease, @tauri-apps/cli with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
previously approved these changes
Aug 21, 2024
tooling/cli/src/mobile/ios/mod.rs
Outdated
| None | ||
| } | ||
| (None, Some(_)) => { | ||
| log::warn!("The IOS_CERTIFICATE_PASSWORD environment variable is set but not IOS_CERTIFICATE. Ignoring the certificate..."); |
There was a problem hiding this comment.
should probably skip this warning, doesn't make sense to check IOS_CERTIFCATE_PASSWORD and not IOS_CERTIFICATE
amrbashir
approved these changes
Aug 21, 2024
amrbashir
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.