Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): cleanup info command #7204

Merged
merged 12 commits into from
Oct 17, 2023
Merged

refactor(cli): cleanup info command #7204

merged 12 commits into from
Oct 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 14, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 14, 2023 17:20
@wusyong wusyong added the status: needs review A maintainer must review this code label Jun 15, 2023
amrbashir
amrbashir commented Jun 15, 2023
View reviewed changes
tooling/cli/src/info/packages_nodejs.rs Outdated Show resolved Hide resolved
tooling/cli/src/info/packages_rust.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog changed the base branch from dev to 1.x June 16, 2023 15:14
martinfrances107
martinfrances107 suggested changes Sep 14, 2023
View reviewed changes
tooling/cli/src/info/packages_rust.rs Outdated Show resolved Hide resolved
tooling/cli/src/info/packages_rust.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 99865d9 into 1.x Oct 17, 2023
13 checks passed
@lucasfernog lucasfernog deleted the refactor/cli/info/cleanup branch October 17, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfrances107 martinfrances107 martinfrances107 requested changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
status: needs review A maintainer must review this code
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrbashir @martinfrances107 @lucasfernog @wusyong