Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix require_literal_leading_dot flipped behavior (#7227) #7233

Closed
wants to merge 1 commit into from
Closed

fix(core): fix require_literal_leading_dot flipped behavior (#7227) #7233

wants to merge 1 commit into from

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 17, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 17, 2023 12:40
@amrbashir amrbashir changed the title fix(core): fix require_literal_leading_dot flipped behavior (#7227) fix(core): fix require_literal_leading_dot flipped behavior Jun 17, 2023
@amrbashir amrbashir changed the title fix(core): fix require_literal_leading_dot flipped behavior fix(core): fix require_literal_leading_dot flipped behavior (#7227) Jun 17, 2023
@lucasfernog
Copy link
Member

I've actually merged from 1.x instead.

@lucasfernog lucasfernog deleted the fix/core/require-leading-dot branch June 17, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 📬Proposal
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog