Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fix panic section on manage documentation #7251

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner June 18, 2023 10:11
@FabianLars
Copy link
Member

FabianLars commented Jun 18, 2023

Am i missing another related change here? Because it does panic if it's already managed.
grafik

Edit: Talking about the Builder, not the Manager trait.

@lucasfernog
Copy link
Member Author

Damn I totally missed the assert in the Builder and only tested the Manager trait. Thanks for catching it.

@lucasfernog lucasfernog merged commit df6712c into 1.x Jun 21, 2023
21 checks passed
@lucasfernog lucasfernog deleted the docs/manage branch June 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants