fix(bundler): Enable zip's deflate feature flag #7296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it affecting v1 too or just v2? |
|
Just v2. In v1 it's enabled by some other dependency so it's not as urgent (though ig it should still be added to be more explicit about it) |
lucasfernog
previously approved these changes
Jun 26, 2023
|
I'd add a change file if we want to hotfix it sooner. |
lucasfernog
approved these changes
Jun 26, 2023
This was referenced Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
unsupported Zip archive: Compression method not supportedbundler errors when it tries to download nsis and wix.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
https://discord.com/channels/616186924390023171/1122606764932739133