-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend context.rs to dynamically find the OUT_DIR for certain assets #7534
Extend context.rs to dynamically find the OUT_DIR for certain assets #7534
Conversation
@sinistersnare is this PR ready or do you want to change some other OUT_DIR usage? |
I think its fine for now. It can be further extended as needed using the code here as a template for future contributors. |
By the way @sinistersnare this PR is targeting v2. So if you want this to be part of v1.5, it needs to target the |
Ah thanks for the check on that. I rebased on 1.x |
I extended the PR to include another case useful to my project. Overall, this kind of stuff is really useful for non-Cargo users, and the codegen crate would be wise to generalize from any build tool. |
Hello, my team is moving to Bazel, and we can not use tauri-cli or any of your custom cargo-based tooling. We would like to contribute our changes to you all, so you can better support Bazel.
These changes should be non-breaking, as it just recalculates the OUT_DIR at build.rs-time and compile-time separately. So it should not affect Cargo builds.
I think that TODO, if this is going to be fully generalized we need to add this functionality to some other parts of at least this file.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information