Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move to muda and tray_icon crates #7535

Merged
merged 130 commits into from
Aug 14, 2023
Merged

refactor: move to muda and tray_icon crates #7535

merged 130 commits into from
Aug 14, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Aug 1, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Closes #6643
Closes #5940
Closes #5645
Closes #4945
Closes #4338
Closes #2803
Closes #2696

amrbashir and others added 30 commits July 14, 2023 01:09
@amrbashir
refactor: migrate to new crates (muda & tray-icon)
262f8f7
@amrbashir
update deps to use git
4734c01
@amrbashir
add tray getters
027c940
@lucasfernog
fix linux impl
d71a11c
@lucasfernog
fix gtk api usage
1a75a13
@lucasfernog
lint
6758525
@lucasfernog
fix build on macos
826a5fc
@amrbashir
disable default features for muda and tray-icon
d57635d
@amrbashir
Merge branch 'refactor/muda-migration' of https://github.com/tauri-ap…
5b13702 
…ps/tauri into refactor/muda-migration
@amrbashir
remove default file menu on Linux
eaa17cd
@amrbashir
use builder on Linux
0063216
@amrbashir
move menu/tray handlers setup from runtime to tauri
ae9423b
@lucasfernog
remove unused messages
0c53ebc
@lucasfernog
Merge remote-tracking branch 'origin/dev' into refactor/muda-migration
d1b81bf
@amrbashir
revert menu changes and enhance docs
37497a1
@amrbashir
add show_context_menu function
80f4f2e
@amrbashir
inital work for menu wrapper types
0b235db
@lucasfernog
fix build on macos [skip ci]
e6fbf76
@amrbashir
ensure thread safety for context items
35dca0d
@amrbashir
finish menu wrapper types
dd36a38
@amrbashir
add default menu
a4391ad
@amrbashir
add tray icon wrapper types
1cf5788
@amrbashir
Merge branch 'dev' into refactor/muda-migration
4cedac2
@lucasfernog
fix macos build
5c8d40b
@lucasfernog
lint
9534f6a
@lucasfernog
small fix on api example
f5b5aac
@lucasfernog
fix linux build
741a2d7
@amrbashir
change Builder::tray_icon to be a function
ad18aac
@amrbashir
Add a getter for apphandle
be77871
@amrbashir
change it to an owned handle
aef5e96
amrbashir
amrbashir commented Aug 10, 2023
View reviewed changes
core/tauri/src/menu/menu.rs Outdated Show resolved Hide resolved
core/tauri/src/menu/menu.rs Outdated Show resolved Hide resolved
core/tauri/src/app.rs Show resolved Hide resolved
@lucasfernog lucasfernog merged commit 7fb419c into dev Aug 14, 2023
34 checks passed
@lucasfernog lucasfernog deleted the refactor/muda-migration branch August 14, 2023 01:25
@hammer hammer mentioned this pull request Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
2 participants
@amrbashir @lucasfernog