Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588 #7591

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588 #7591

merged 3 commits into from
Aug 15, 2023

Conversation

jetli
Copy link
Contributor

@jetli jetli commented Aug 11, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@jetli jetli requested a review from a team as a code owner August 11, 2023 09:04
@amrbashir amrbashir changed the title fix(bundler/nsis): delete app data of current user when uninstall, closes #7588 fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588 Aug 15, 2023
@amrbashir amrbashir merged commit ca977f4 into tauri-apps:1.x Aug 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetli @amrbashir