Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: extend tauri builder with updater_header method #7640

Closed
wants to merge 1 commit into from

Conversation

Atrox
Copy link

@Atrox Atrox commented Aug 16, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This change extends tauri::Builder with a new method updater_header (in the same vein as the existing updater_target) to set headers on the default updater instance.

@Atrox Atrox requested a review from a team as a code owner August 16, 2023 14:54
@Atrox Atrox force-pushed the feature/builder-updater-headers branch from 9ea755b to 196e16c Compare January 31, 2024 11:10
@amrbashir
Copy link
Member

amrbashir commented Feb 14, 2024

Thanks for your contribution, but since updater in v2 has been moved to its own plugin, and since we already provide a similar API https://docs.rs/tauri/latest/tauri/updater/struct.UpdateBuilder.html#method.header, I will close this PR in order to avoid another breaking change.

@amrbashir amrbashir closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants