Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no longer unpacking and flattening payload, closes #7673 #7677

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

simonhyll
Copy link
Contributor

@simonhyll simonhyll commented Aug 22, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Issue: #7673

Copy link
Member

@JonasKruckenberg JonasKruckenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this doesn't fix the bug in question it's a good change 👍

@simonhyll
Copy link
Contributor Author

A user reported this only fixes it on Linux, so I'll see if I can figure out the Windows issue as well. Can't do much about Mac.

@nikoPLP
Copy link

nikoPLP commented Aug 23, 2023

A user reported this only fixes it on Linux, so I'll see if I can figure out the Windows issue as well. Can't do much about Mac.

Tested right now on macos, it fixes the use of options in the command args.

@simonhyll
Copy link
Contributor Author

I can't for the life of me figure out why Windows is crashing. I'd say merge this and someone else take over making Windows work.

@reyamir
Copy link

reyamir commented Aug 25, 2023

sadly, this issue really serious

@amrbashir
Copy link
Member

Flattening is indeed bad, I think there was an issue with it in v1, and so we shouldn't flatten at all.
I would still wait for @lucasfernog to merge this since he is the one familiar with this piece of code.

@lucasfernog lucasfernog merged commit e98393e into tauri-apps:dev Sep 4, 2023
18 checks passed
@LetrixZ
Copy link

LetrixZ commented Sep 5, 2023

I tried this on macOS with the dialog plugin and it still freezes. Seems to be an issue with the custom protocol that only runs on Windows and macOS.
Linux works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

7 participants