-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no longer unpacking and flattening payload, closes #7673 #7677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if this doesn't fix the bug in question it's a good change 👍
A user reported this only fixes it on Linux, so I'll see if I can figure out the Windows issue as well. Can't do much about Mac. |
Tested right now on macos, it fixes the use of |
I can't for the life of me figure out why Windows is crashing. I'd say merge this and someone else take over making Windows work. |
sadly, this issue really serious |
Flattening is indeed bad, I think there was an issue with it in v1, and so we shouldn't flatten at all. |
I tried this on macOS with the |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Issue: #7673