Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): migration tests #7745

Merged
merged 3 commits into from
Sep 6, 2023
Merged

fix(cli): migration tests #7745

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c06146b
fix(cli): migration tests
lucasfernog Sep 4, 2023
f4ece36
lint
lucasfernog Sep 4, 2023
a2bfd2b
Merge branch 'dev' into fix/cli-tests
lucasfernog Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tooling/cli/src/migrate/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ mod tests {
.as_array()
.expect("features must be an array")
.clone();

if toml.contains("reqwest-native-tls-vendored") {
assert!(
features
Expand All @@ -233,10 +234,22 @@ mod tests {
"reqwest-native-tls-vendored was not replaced with native-tls-vendored"
);
}

if toml.contains("system-tray") {
assert!(
features
.iter()
.any(|f| f.as_str().expect("feature must be a string") == "tray-icon"),
"system-tray was not replaced with tray-icon"
);
}

for feature in features.iter() {
let feature = feature.as_str().expect("feature must be a string");
assert!(
keep_features.contains(&feature) || feature == "native-tls-vendored",
keep_features.contains(&feature)
|| feature == "native-tls-vendored"
|| feature == "tray-icon",
"feature {feature} should have been removed"
);
}
Expand Down
Loading