-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): custom protocol on Windows now uses the http scheme #7779
Conversation
Am i right to assume that we don't want this to be configurable? I'm asking because i'd lean towards closing #7645 if that's the case. |
I think for v1 it's valuable to add a config option for it (since it's a popular issue). For v2 I don't really want to bloat the code with this check, though it could be added if the community / security team feels it's a nice addition (though it sucks that it only helps windows/android). |
Yeah, it's just that adding a new but deprecated API has a bit of a weird vibe but alright, at least the PR wasn't wasted time then :D And in v2 I think a better request API (basically on_navigation but for everything) would solve the problem better than the https scheme since it would be cross platform. |
Hi @lucasfernog, Why Windows use |
allows for connecting to insecure protocols like |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information