Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): custom protocol on Windows now uses the http scheme #7779

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner September 7, 2023 20:00
@lucasfernog lucasfernog merged commit 4cb51a2 into dev Sep 7, 2023
33 checks passed
@lucasfernog lucasfernog deleted the fix/windows-custom-protocol-url branch September 7, 2023 22:57
@FabianLars
Copy link
Member

Am i right to assume that we don't want this to be configurable? I'm asking because i'd lean towards closing #7645 if that's the case.

@lucasfernog
Copy link
Member Author

I think for v1 it's valuable to add a config option for it (since it's a popular issue). For v2 I don't really want to bloat the code with this check, though it could be added if the community / security team feels it's a nice addition (though it sucks that it only helps windows/android).

@FabianLars
Copy link
Member

Yeah, it's just that adding a new but deprecated API has a bit of a weird vibe but alright, at least the PR wasn't wasted time then :D

And in v2 I think a better request API (basically on_navigation but for everything) would solve the problem better than the https scheme since it would be cross platform.

@percy507
Copy link

Hi @lucasfernog,

Why Windows use http scheme now instead of https? I mean no harm. Just curious.

@amrbashir
Copy link
Member

allows for connecting to insecure protocols like ws instead of wss which has been the main reason for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

5 participants