-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core&api)!: hide internal functions and reuse them in api.js & rename tauri
module to primitives
#7942
Conversation
tauri
module to primitives
tauri
module to primitives
tauri
module to primitives
There's a reason we're not adding everything on TAURI: we replace that whole object if withGlobalTauri is set to true: tauri/tooling/api/tsup.config.ts Line 31 in c0d03af
I pushed some changes on your script, but that part of this PR can't be touched (unless we rename TAURI to something else for core scripts). |
I guess we need to change the place we store these internals, or change |
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @sveltejs/[email protected] |
Moved to |
tauri
module to primitives
tauri
module to primitives
ref: #7756
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
This PR aims to hide all internal functions and properties from the global
window
object and towindow.__TAURI__.__INTERNALS__
and also changes@tauri-apps/api
to use these functions instead of redefining the logic again.Also renamed
tauri
module toprimitives
and removed the undocumentedinvoke
re-export in the root module.