Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: consistent environment variables #7949

Merged
merged 6 commits into from
Oct 17, 2023
Merged

refactor!: consistent environment variables #7949

merged 6 commits into from
Oct 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Oct 3, 2023 •
edited
Loading

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 3, 2023 18:16
@amrbashir amrbashir mentioned this pull request Oct 3, 2023
Closed
14 tasks
FabianLars
FabianLars reviewed Oct 4, 2023
View reviewed changes
.changes/cli-env-vars.md Outdated Show resolved Hide resolved
.changes/tauri-env-vars.md Outdated Show resolved Hide resolved
tooling/cli/ENVIRONMENT_VARIABLES.md Outdated Show resolved Hide resolved
tooling/cli/src/build.rs Outdated Show resolved Hide resolved
tooling/cli/src/build.rs Outdated Show resolved Hide resolved
tooling/cli/src/build.rs Outdated Show resolved Hide resolved
tooling/cli/src/build.rs Outdated Show resolved Hide resolved
tooling/cli/src/mobile/mod.rs Outdated Show resolved Hide resolved
tooling/cli/src/signer/generate.rs Outdated Show resolved Hide resolved
@FabianLars
Copy link
Member

oh god, should not have used the suggestion feature for that. That's spammy af, sorry...

@lucasfernog lucasfernog merged commit 8b166e9 into dev Oct 17, 2023
2 checks passed
@lucasfernog lucasfernog deleted the refactor/consistent-env-vars branch October 17, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @FabianLars @lucasfernog