-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundler): read http_proxy env when downloading resources, closes #7985. #8008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, could you also add a change file in .changes
directory? and can you please sign your commits, otherwise we can't merge this PR. You need to setup commit signing, then you can sign past commit like this for example.
Does signing require only the latest commit or every commits? |
Also, I think this change applies to version 1.x as well, should I reopen a new PR? |
yeah all commits must be signed and you also need to only target 1.x branch |
Signed-off-by: CaiJingLong <[email protected]>
Because I need to sign all commits, so I rebase all commits and force push. If this PR can be passed, I will open new PR and for 1.x branch. |
You don't need to open a PR for |
OK, I'll reopen new PR for 1.x. |
I open #8012 for branch 1.x. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information