Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): read http_proxy env when downloading resources, closes #7985. #8008

Closed
wants to merge 1 commit into from

Conversation

CaiJingLong
Copy link
Contributor

@CaiJingLong CaiJingLong commented Oct 12, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, could you also add a change file in .changes directory? and can you please sign your commits, otherwise we can't merge this PR. You need to setup commit signing, then you can sign past commit like this for example.

tooling/bundler/src/bundle/windows/util.rs Outdated Show resolved Hide resolved
@CaiJingLong
Copy link
Contributor Author

Does signing require only the latest commit or every commits?
In other words, do I need to force push?

@CaiJingLong
Copy link
Contributor Author

Also, I think this change applies to version 1.x as well, should I reopen a new PR?

@amrbashir
Copy link
Member

yeah all commits must be signed and you also need to only target 1.x branch

@CaiJingLong
Copy link
Contributor Author

Because I need to sign all commits, so I rebase all commits and force push.


If this PR can be passed, I will open new PR and for 1.x branch.

@amrbashir
Copy link
Member

You don't need to open a PR for dev since 1.x will be merged into dev later, so you only need to rebase your branch on 1.x and re-target this PR to 1.x

@CaiJingLong
Copy link
Contributor Author

You don't need to open a PR for dev since 1.x will be merged into dev later, so you only need to rebase your branch

OK, I'll reopen new PR for 1.x.

@CaiJingLong
Copy link
Contributor Author

I open #8012 for branch 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants