fix(cli): regression on --config not accepting file paths #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Feb 5, 2024
tooling/cli/src/build.rs
Outdated
| options.config = merge_config; | ||
|
|
||
| let config = get_config(target, options.config.as_deref())?; | ||
| let config = get_config(target, options.config.as_ref().map(|c| &c.0))?; |
There was a problem hiding this comment.
can't we just config as an argument to the setup function?
There was a problem hiding this comment.
we do not do this overall in the codebase, get_config is cached so it's cheap if it's already been resolved, otherwise we need to pass the config around all codebase
There was a problem hiding this comment.
yeah, but config is parsed right before calling setup so it is better to just pass the config to it, than getting from cache again
There was a problem hiding this comment.
you're right it wasn't that complicated in the end.. thanks
amrbashir
reviewed
Feb 5, 2024
|
stupid android test CI still broken.. |
amrbashir
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.