Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): CLI path issues on mobile project initialization #9009

Merged
merged 17 commits into from
Feb 28, 2024
Merged

fix(cli): CLI path issues on mobile project initialization #9009

merged 17 commits into from
Feb 28, 2024

Conversation

amrbashir
Copy link
Member

closes #8531

@amrbashir amrbashir requested a review from a team as a code owner February 27, 2024 18:58
@lucasfernog lucasfernog changed the title fix(cli): fix panic when android init using cargo or yarn fix(cli): overwrite and CLI path issues on mobile project initialization Feb 28, 2024
@lucasfernog lucasfernog changed the title fix(cli): overwrite and CLI path issues on mobile project initialization fix(cli): file overwriting and CLI path issues on mobile project initialization Feb 28, 2024
@lucasfernog
Copy link
Member

Pushing some changes so we still consider the issue fixed by #8128 and also make the project setup more flexible (i.e. right now you can't determine a NPM script to initialize the project, because it would try to run npm run <your-init-script> android-studio-script)

@amrbashir
Copy link
Member Author

nice, I was wondering why the relativizing existed in the first place and was hoping you'd know.

@amrbashir amrbashir mentioned this pull request Feb 28, 2024
Merged
@lucasfernog lucasfernog changed the title fix(cli): file overwriting and CLI path issues on mobile project initialization fix(cli): CLI path issues on mobile project initialization Feb 28, 2024
lucasfernog
lucasfernog approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hope we got this right this time :D

@lucasfernog lucasfernog merged commit f5f3ed5 into dev Feb 28, 2024
16 checks passed
@lucasfernog lucasfernog deleted the fix/cli/android-init-yarn-cargo-windows branch February 28, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tauri android init internal error: entered unreachable code: abs_src and abs_dest have no common root
2 participants
@amrbashir @lucasfernog