fix(ipc): fallback to postMessage if protocol fails, closes #8476 #9038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
approved these changes
Feb 29, 2024
|
@lucasfernog Also I when it fallback to postMessage if I return any object value (eg serde_json::Value) the promise doesn't resolve on webview2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the IPC mechanism to always support the custom-protocol and postMessage variants. The frontend now handles the custom protocol fetch call failing (usually due to CSP or webview denying access to the protocol) and fallbacks to the postMessage API).
The fixes for #7662 (#7751, #7754 and #7764) are still valid.
This is a more generic approach to #8887