fix(macos): clear_all_browsing_data segfault with null completionHandler

the completionHandler cannot be null: https://developer.apple.com/documentation/webkit/wkwebsitedatastore/1532936-removedata
tauri-apps · Sep 20, 2024 · 50ebc05 · 50ebc05
1 parent ba5b1e0
commit 50ebc05
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/fix-clear-browsing-data-macos.md b/.changes/fix-clear-browsing-data-macos.md
@@ -0,0 +1,5 @@
+---
+"wry": patch
+---
+
+Fixes `WebView::clear_all_browsing_data` crashing with a segfault on macOS.
diff --git a/src/wkwebview/mod.rs b/src/wkwebview/mod.rs
@@ -1136,7 +1136,7 @@ r#"Object.defineProperty(window, 'ipc', {
       let store: id = msg_send![config, websiteDataStore];
       let all_data_types: id = msg_send![class!(WKWebsiteDataStore), allWebsiteDataTypes];
       let date: id = msg_send![class!(NSDate), dateWithTimeIntervalSince1970: 0.0];
-      let handler = null::<*const c_void>();
+      let handler = block::ConcreteBlock::new(move || {}).copy();
       let _: () = msg_send![store, removeDataOfTypes:all_data_types modifiedSince:date completionHandler:handler];
     }
     Ok(())