Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android): use http scheme by default for custom protocols and add option to change it ref #994 #1020

Merged
merged 3 commits into from
Sep 8, 2023
Merged

refactor(android): use http scheme by default for custom protocols and add option to change it ref #994 #1020

merged 3 commits into from
Sep 8, 2023

Conversation

lucasfernog
Copy link
Member

…d add option to change it ref #994

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner September 8, 2023 10:37
amrbashir
amrbashir requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the documentation on with_custom_protocol methods and related places about custom protocol

@amrbashir amrbashir merged commit 5adf9da into dev Sep 8, 2023
7 checks passed
@amrbashir amrbashir deleted the refactor/http-protocol-android branch September 8, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfernog @amrbashir