Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix benchmark in CI #1051

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix(ci): Fix benchmark in CI #1051

merged 2 commits into from
Oct 29, 2023

Conversation

olivierlemasle
Copy link
Contributor

  • Add --no-install-recommends to apt-get install command, which stops installing xdg-desktop-portal-gtk, which made the benchmarks to run about 30 times slower.
  • Stop using deprecated actions-rs GitHub actions
  • Update hyperfine
  • Clippy fixes in bench code

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

Benchmark results (running in GitHub Actions):

{
  "created_at": "2023-10-26T20:54:18Z",
  "sha1": "4513fb073ba5136962d94be24dee26b112fd30d4",
  "exec_time": {
    "wry_custom_protocol": {
      "system": 0.0714027,
      "user": 0.14192854000000002,
      "min": 0.8725552358,
      "stddev": 0.01756320294129718,
      "mean": 0.8883356643999999,
      "max": 0.9214953298
    },
    "wry_cpu_intensive": {
      "mean": 9.1147323695,
      "stddev": 0.3139193863963647,
      "user": 0.18347473999999991,
      "system": 0.0666227,
      "max": 9.3391904678,
      "min": 8.5209664118
    },
    "wry_hello_world": {
      "system": 0.06789239999999999,
      "user": 0.15248433999999994,
      "max": 0.9439270368,
      "stddev": 0.02301975594994049,
      "min": 0.8771616618,
      "mean": 0.9071919307
    }
  },
  "binary_size": {
    "tao_rlib": 4300464,
    "wry_rlib": 933768,
    "wry_custom_protocol": 1541280,
    "wry_cpu_intensive": 1545568,
    "wry_hello_world": 1532168
  },
  "max_memory": {
    "wry_hello_world": 368050176,
    "wry_cpu_intensive": 465567744,
    "wry_custom_protocol": 351272960
  },
  "thread_count": {
    "wry_cpu_intensive": 60,
    "wry_hello_world": 56,
    "wry_custom_protocol": 55
  },
  "syscall_count": {
    "wry_cpu_intensive": 32786,
    "wry_custom_protocol": 21736,
    "wry_hello_world": 21896
  },
  "cargo_deps": {
    "Linux": 161,
    "macOS": 60,
    "Windows": 56
  }
}

@olivierlemasle olivierlemasle requested review from a team as code owners October 26, 2023 20:59
- Add --no-install-recommends to apt-get install command, which stops
  installing xdg-desktop-portal-gtk, which make the benchmarks to
  run about 30 times slower.
- Stop using deprecated actions-rs GitHub actions
- Update hyperfine
@wusyong wusyong merged commit 81cfa37 into tauri-apps:dev Oct 29, 2023
6 checks passed
@olivierlemasle olivierlemasle deleted the bench branch October 29, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants