Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unix): fix feature gate on WebviewExtUnix #1068

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 9, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

WebviewExtUnix trait is only enabled when target_os is "linux". However, as its name says, it should be enabled on all *nix platforms. webkit2gtk crate is also imported with the same feature gate.

I didn't make a change file for this since WebviewExtUnix is not published yet. This change can be amended to changes of #1041.

@rhysd rhysd requested a review from a team as a code owner November 9, 2023 14:53
@wusyong wusyong merged commit 587d4a4 into tauri-apps:dev Nov 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants