feat(unix): move new_gtk functions to *ExtUnix traits
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rhysd <[email protected]>
rhysd
force-pushed
the
webview-builder-ext-unix
branch
from
933ca76
to
f5e6717
Compare
|
I'm fine with the move. @amrbashir Are you also happy to see this move to extended trait? |
wusyong
previously approved these changes
Nov 13, 2023
|
Can you move this trait into webkitgtk module and reexport it? |
|
Sure. I will try it tonight. |
|
@wusyong Which trait do you mean by 'this trait'? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ah, I'm sorry that I overlooked your sentence 'reexport it'. It is not a breaking chagne. |
amrbashir
previously approved these changes
Nov 13, 2023
amrbashir
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
new_gtkfunctions should be moved to*ExtUnixtraits #1069Other information
Though this PR changes APIs, it is not a breaking change because
new_gtkfunctions are not published yet. This PR's change can be amended to changes of #1041 so I didn't make a change file.