Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with miri to CI #1071

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add tests with miri to CI #1071

merged 1 commit into from
Nov 13, 2023

Conversation

pcwizz
Copy link
Contributor

@pcwizz pcwizz commented Nov 10, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@pcwizz pcwizz requested review from a team as code owners November 10, 2023 16:46
@wusyong
Copy link
Member

wusyong commented Nov 11, 2023

Thanks for the PR!
But miri cannot run through FFI AFAIK. Do you have any result or action report test on your side?

@pcwizz
Copy link
Contributor Author

pcwizz commented Nov 11, 2023

Thanks for the PR! But miri cannot run through FFI AFAIK. Do you have any result or action report test on your side?

Most of the unit tests don't do any FFI, so I figured it was useful to have the coverage with miri where it is possible.

Miri didn't flag anything. I just think it is a useful sanity check to have.

@wusyong wusyong merged commit dbea0f3 into tauri-apps:dev Nov 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants