Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): properly use $wry on android_binding macro #1075

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

The android_binding macro fails to compile due to the use $wry::prelude::*; with expected { or * error.

Regression from #1041 which was not released yet so I didn't add a change file.

The android_binding macro fails to compile due to the `use $wry::prelude::*;` with `expected { or *` error.

Regression from #1041 which was not released yet so I didn't add a change file.
@lucasfernog lucasfernog requested a review from a team as a code owner November 12, 2023 10:15
@amrbashir amrbashir merged commit d2f4220 into dev Nov 12, 2023
10 checks passed
@amrbashir amrbashir deleted the fix/android-binding branch November 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants