Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine position and size into bounds #1079

Merged
merged 5 commits into from
Nov 14, 2023
Merged

refactor: combine position and size into bounds #1079

merged 5 commits into from
Nov 14, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Nov 14, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir requested a review from a team as a code owner November 14, 2023 00:20
@amrbashir
Copy link
Member Author

macOS needs to be tested

amrbashir
amrbashir commented Nov 14, 2023
View reviewed changes
src/wkwebview/mod.rs Outdated Show resolved Hide resolved
@pewsheen
Copy link
Contributor

macOS needs to be tested

It works very well

@wusyong wusyong merged commit fee99b6 into dev Nov 14, 2023
10 checks passed
@wusyong wusyong deleted the refactor/bounds branch November 14, 2023 06:49
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @pewsheen @wusyong