Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use activateIgnoringOtherApps on older macOS versions #1389

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner October 14, 2024 10:45
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Package Changes Through 94dea1d

There are 1 changes which include wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
wry 0.46.0 0.46.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir mentioned this pull request Oct 14, 2024
75 tasks
@lucasfernog
Copy link
Member

I think we should only call activate() when we want to focus the window right? sometimes we do not want that..

@lucasfernog lucasfernog merged commit 33c0193 into dev Oct 14, 2024
12 of 13 checks passed
@lucasfernog lucasfernog deleted the fix/macos-crash-activate-older-than-14 branch October 14, 2024 23:57
@amrbashir
Copy link
Member Author

I think we should only call activate() when we want to focus the window right? sometimes we do not want that..

I honestly don't know why this call is here, but viewing the git blame, it was added in #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Tauri + Dioxus App Crash on macos with 2.0
2 participants