feat: add WebView::cookies and WebView::cookies_for_url
#1394
Conversation
Package Changes Through f307f71There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
src/wkwebview/mod.rs
Outdated
| // domain is the same | ||
| cookie.domain() == url.domain() | ||
| // path is the same | ||
| && cookie.path() == Some(url.path()) | ||
| /// and one of | ||
| && ( | ||
| // cookie is secure and url is https | ||
| (cookie.secure() && url.scheme() == "https") || | ||
| // or cookie is secure and is localhost | ||
| ( | ||
| cookie.secure() && url.scheme() == "http" && | ||
| (url.domain() == Some("localhost") || url.domain().and_then(|d| Ipv4Addr::from_str(d).ok()).map(|ip| ip.is_loopback()).unwrap_or(false)) | ||
| ) || | ||
| // or cookie is not secure | ||
| (!cookie.secure()) | ||
| ) |
There was a problem hiding this comment.
not sure if this is too restrictive, tried to check how webkit2gtk cookies_for_url is implementation but I think their implementation is a bit more relaxed ? https://github.com/WebKit/WebKit/blob/c305a86965236fd8052623faaf8804b1424e7f6b/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp#L69
There was a problem hiding this comment.
when in doubt just ask @tweidinger though I think we should just match the behavior from other platforms if possible
There was a problem hiding this comment.
I think we do match too strict on the path depending on the cookie policy.
For example / in the cookie would not match a subpath cookie but it should match any path.
There was a problem hiding this comment.
Just checking the domain match and checking if secure cookie or not sounds acceptable if we don't want to implement the cookie specs fully 😁 .
There was a problem hiding this comment.
alright, pushed a change to match on domain and secure or not. (basically just removed matching the path)
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
closes #518
ref: tauri-apps/tauri#11330