app refactored as stand-alone widget #4
Conversation
| def override_mousePressEvent(widget, button, callback): | ||
| old_hook = widget.mousePressEvent | ||
| def mousePressEvent(obj, event): | ||
| if event.button() == button: | ||
| callback(obj, event) | ||
| old_hook(event) | ||
| widget.mousePressEvent = types.MethodType(mousePressEvent, widget) | ||
|
|
||
| override_mousePressEvent(self.ui.listView, | ||
| Qt.Qt.RightButton, self.onContextMenu) |
There was a problem hiding this comment.
This part looks like quite a hack... I would try to avoid intercepting mouse press events (and events in general) and use higher level Qt APIs instead.
...and if working with events is absolutely mandatory, I would consider using an event filter
| import fandango | ||
| import fandango as fn | ||
| import fandango.qt |
There was a problem hiding this comment.
I would not introduce fandango as a dependency. On a quick look it seems that some of these imports are not even used, and others are quite trivial utility helpers that could be easily replaced
(I mark it here, but there are other similar imports in the other files)
| @@ -0,0 +1,181 @@ | |||
| ===================================== | |||
There was a problem hiding this comment.
What is the purpose of this file?
Is it the seed for some documentation or is it a collection of personal development notes?
| #plot.setDropLogger(fandango.printf) | ||
| #plot.setSupportedMimeTypes(fandango.qt.MIMETYPES) | ||
|
|
||
| plot.setBackgroundBrush(Qt.QColor('white')) |
There was a problem hiding this comment.
IMHO, we should keep visual consistency among the various taurus* "oficial" projects (at least those under the taurus-org umbrella).
In that sense, I think that we should not be changing the background of the plots here, but intead do it either in taurus_pyqtgraph in general, or in a final application outside tango-archiving.
If we want to do it in general, we need to consider things with some care (that is why it hasn't been done yet)... but I think this is a time as good as any other to start the discussion, so I created this issue in taurus_pyqtgraph
There was a problem hiding this comment.
the same comment is obviously valid for the other usages of setBackgroundBrush()
|
Ok, do the changes you consider necessary, as long as it keeps the current functionality. |
to integrate it into another applications, it must be an independent widget
I refactored the code of tpgarchiving into tpgarchivingwidget
original file not modified