Change how Faraday does auth #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
culley-stripe
force-pushed
the
upgrade_faraday
branch
2 times, most recently
from
1aa5753
to
23bb1d4
Compare
change Faraday authorization methodology more liberal versioning of Faraday no longer need to sanitize token in url remove trailing slash from DEFAULT_URL
culley-stripe
force-pushed
the
upgrade_faraday
branch
from
23bb1d4
to
4a5bd95
Compare
culley-stripe
commented
May 9, 2024
| @@ -8,7 +8,6 @@ def initialize(response) | |||
|
|
|||
| def get_response_info(response) | |||
| url = response.env.url | |||
| url.query = url.query.sub(/token=[^&]*/, 'token=**SECRET**') | |||
There was a problem hiding this comment.
We no longer have the token, aka query, set as we put token in the headers now.
culley-stripe
commented
May 9, 2024
| @@ -13,7 +13,7 @@ class Client | |||
| extend Forwardable | |||
|
|
|||
| # The default base URL for the Ecwid API | |||
| DEFAULT_URL = "https://app.ecwid.com/" | |||
| DEFAULT_URL = "https://app.ecwid.com" | |||
There was a problem hiding this comment.
The trailing slash in the DEFAULT_URL is causing a double slash to be in the url, which faraday does not like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.