Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax faraday and faraday_middleware dependency #21

Closed
wants to merge 1 commit into from
Closed

relax faraday and faraday_middleware dependency #21

wants to merge 1 commit into from

Conversation

ashkulz
Copy link

@ashkulz ashkulz commented Jan 15, 2021

This was blocking us from upgrading to faraday 1.0

@Willardgmoore
Copy link

I should have checked other PR's before adding mine. @ashkulz Did you run tests or anything? Idk if that would help them approve the PR any sooner.

@ashkulz
Copy link
Author

ashkulz commented Mar 1, 2021

TravisCI reports a failure on account of CVE-2020-8130, need to specify rake >= 12.3.3. Everything works for our limited usage with this PR, so I didn't really check further 🤷‍♂️

@Willardgmoore
Copy link

If this pr doesn't get accepted soon then I might just use your fork for now in my gemfile

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@waghanza
Copy link

waghanza commented Nov 16, 2022

I've made #25, maybe we can combine our efforts

@teamsimplepay teamsimplepay closed this by deleting the head repository Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants