Fix issue related to saving customers #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey Taxjar team Any plans to merge this PR? Your extension may not work correctly with supported versions of Magento without this update. We're currently relying on a patch I created in our project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request fixes issue #375
Description
This fixes the bug in issue #375
Performance
No impact on performance - It adds null checks.
Testing
You can test this by replicating the issue in #375 and then applying this patch and seeing if it still causes the issue. After doing these changes, we stopped having that particular issue and were again able to save customer accounts as expected.
Versions