Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#258 Stop displaying the metabox when the order can't be found #262

Merged
merged 1 commit into from
Aug 19, 2024
Merged

#258 Stop displaying the metabox when the order can't be found #262

merged 1 commit into from
Aug 19, 2024

Conversation

ahumulescu
Copy link
Collaborator

This PR:

  • Adds a fix for the issue number #258

Steps to reproduce

  • Go to WordPress admin -> WooCommerce -> Settings -> Advanced -> Features -> enable HPOS
  • Go to an admin product page and scroll to the bottom of the page

Expected Result

  • The TaxJar metabox not being displayed, as this is not an order page

After applying the PR, this should happen.

  • The TaxJar metabox will be displayed only for the order pages

Click-Test Versions

  • Woo 9.0

Specs Passing

  • Woo 9.0

@ahumulescu ahumulescu mentioned this pull request Aug 11, 2024
Open
@alis-stripe
Copy link

@ahumulescu I untagged Lee and I as the current runner will be reviewing this PR. We're tracking this ask in a RUN ticket for our team.

@saville-stripe saville-stripe self-requested a review August 19, 2024 19:30
saville-stripe
saville-stripe approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@saville-stripe saville-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and I was able to see the meta box disappear with this work on the new product page

@saville-stripe saville-stripe merged commit f460a3e into master Aug 19, 2024
1 check passed
@saville-stripe saville-stripe deleted the 258-fatal-error-in-product-page branch August 19, 2024 20:36
@saville-stripe
Copy link
Contributor

This was released as part of 4.2.3. Thanks @ahumulescu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saville-stripe saville-stripe saville-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahumulescu @alis-stripe @saville-stripe