Improve the "locked out" message shown when someone tries to edit a roster or mark attendance #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roster, or mark attendances, but can't because someone else has the lock. The message now says who has the lock (so they can perhaps be contacted), as well as how long until it times out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At our church, we often have situations where someone has a lock on something, but we don't know who to tell them to Get On With It. This patch improves the locked-out message to say who has the lock, and for how long.
The code handles the situation where multiple users have locks for different sets of roster roles. It also handles the situation where the lock requester doesn't have permission to see the lock holder (their
personview doesn't have the lock-holder).Old:
New:
Old:
New: