Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Waveshare 1.54" ePaper #1703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtavenrath
Copy link

This is a minimal invasive version of @dAjaY85's ePaper integration with a few fixes. Until this has been merged it should be way easier to rebase it without the merge conflicts due to the renaming of the DisplayClass.

@mtavenrath mtavenrath force-pushed the epaper154 branch 2 times, most recently from 64b7640 to b7d11e6 Compare January 30, 2024 22:33
@zoeck-dev
Copy link

I hope that the pull request will be integrated into the master branch.

I would like to switch to OpenDTU, but I am already using the ePaper Display with AhoyDTU. I don't really want to buy a new display :)

@mtavenrath
Copy link
Author

I've updated the PR to master & fixed the issue with the display not updating the last timestamp.

@stefan123t
Copy link

@mtavenrath could you also check if there is still something missing regarding the merge of #2306 this week ?

@mtavenrath
Copy link
Author

@stefan123t To my best understanding the ePaper support does not require the SPI manager since it added a SW SPI implementation to the waveshare library. Thus no changed are required for the SPI manager itself.

@tbnobody I tried to rebase the change again today and it's again quite some work due to the changes to the display classes. Before rebasing this again, is there a chance to get this change merged? There is a slight difference in how the two different display classes work which results made @dAjaY85 implement two display classes, one for the ePaper which less frequent updates and one for 'realtime' displays. Everytime the display class interface is changed I have to figure out the changes and apply them to both classes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants