Editorial: mark a note step as a note #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Mar 8, 2023
syg
approved these changes
Mar 15, 2023
michaelficarra
added
the
ready to merge
ljharb
pushed a commit
that referenced
this pull request
Mar 15, 2023
ljharb
force-pushed
the
mark-note
branch
2 times, most recently
from
22babed
to
8d3d3cf
Compare
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Mar 18, 2023
PR tc39#3026 converted the step: > Once a generator enters the ~completed~ state it never leaves it and its associated execution context is never resumed. Any execution state associated with _acGenerator_ can be discarded at this point. in GeneratorStart into a Note. This commit converts the similar step in GeneratorResumeAbrupt into a Note too.
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Mar 21, 2023
PR tc39#3026 converted the step: > Once a generator enters the ~completed~ state it never leaves it and its associated execution context is never resumed. Any execution state associated with _acGenerator_ can be discarded at this point. in GeneratorStart into a Note. This commit converts the similar step in GeneratorResumeAbrupt into a Note too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2962.