Skip to content

Editorial: add a note about synchronicity of SyntheticModule Evaluate #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Editorial: add a note about synchronicity of SyntheticModule Evaluate #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26779,6 +26779,7 @@ <h1>Abstract Module Records</h1>
<td>
<p>Returns a promise for the evaluation of this module and its dependencies, resolving on successful evaluation or if it has already been evaluated successfully, and rejecting for an evaluation error or if it has already been evaluated unsuccessfully. If the promise is rejected, hosts are expected to handle the promise rejection and rethrow the evaluation error.</p>
<p>Link must have completed successfully prior to invoking this method.</p>
<p>A non Cyclic Module Record must always returns a settled promise. This is asserted in InnerModuleEvaluation, and a non Cyclic Module Record is evaluated with EvaluateModuleSync.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>A non Cyclic Module Record must always returns a settled promise. This is asserted in InnerModuleEvaluation, and a non Cyclic Module Record is evaluated with EvaluateModuleSync.</p>
<p>A non Cyclic Module Record must always returns a settled promise.</p>

From a host point view the only thing that matters is what they have to do, and not what algorithms would break if they don't. Similarly, for "Link must have completed successfully prior to invoking this method" we do not say that that's asserted in step 2 of Evaluate.

(and if we do need to link, we should do it so through <emu-xref> so that it stays up to date)

</td>
</tr>
</table>
Expand Down Expand Up @@ -28738,7 +28739,7 @@ <h1>Synthetic Module Records</h1>
<tr>
<td>[[EvaluationSteps]]</td>
<td>an Abstract Closure</td>
<td>The initialization logic to perform upon evaluation of the module, taking the Synthetic Module Record as its sole argument. It must not modify [[ExportNames]]. It may return an abrupt completion.</td>
<td>The initialization logic to perform upon evaluation of the module, taking the Synthetic Module Record as its sole argument. It must not modify [[ExportNames]]. It returns either normal completion containing ~unused~, or a throw completion.</td>
</tr>
</table>
</emu-table>
Expand Down