-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dark Mode #632
base: main
Are you sure you want to change the base?
Support Dark Mode #632
Conversation
We don't have a dark-mode Ecma logo, so for now that'll have to have a light background applied to it as well. My initial reaction is that the main document background is way too dark, creating eye-searing contrast with the body text. Why isn't it a similar tone to the left and bottom panes? I'd like to see what an accessibility analysis says about this. Can you run Lighthouse (or some other accessibility tool) on the result, or host it on gh-pages so we can do it ourselves? |
Okay, I've added #fff background to it as well.
The color was just the opposite of the original color/background-color.
Pushed the output to https://arai-a.github.io/ecmarkup/out/ I'll check the accessibility details. |
I see several issues with the contrast in the accessibility details, such as the parameter with highlight, hljs highlight, note section, etc. I'll address them to match the requirements and post update. |
Fixed colors, so that at WCAG contrast score becomes AAA or AA for the most cases. The output is available in: https://arai-a.github.io/ecmarkup/out/ |
This adds dark mode for the spec.
The colors and the variable names are chosen without much consideration, and I'm open to any changes.
There are some issue with the transparent images, such as the ECMA logo.
If there's dark-mode logo or any other solution, let me know.
For other images in figure, I've added always-#fff background color.