-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase against Element Android v1.6.22 #1109
base: develop
Are you sure you want to change the base?
Conversation
…deLogin Remove legacy qr code login
…rUtils Add unit test on ScanEncryptorUtils.
https://github.com/uhoreg/matrix-doc/blob/symmetric_ssss/proposals/2472-symmetric-ssss.md "The m.secret_storage.v1.curve25519-aes-sha2 method proposed in MSC1946 is removed."
…e it will not crash the application.
"See and managed addresses" typo fixed.
Upgrade Jitsi to 10.2.0
Bumps [org.matrix.rustcomponents:crypto-android](https://github.com/matrix-org/matrix-rust-components-kotlin) from 0.4.1 to 0.4.3. - [Release notes](https://github.com/matrix-org/matrix-rust-components-kotlin/releases) - [Commits](matrix-org/matrix-rust-components-kotlin@crypto-v0.4.1...crypto-v0.4.3) --- updated-dependencies: - dependency-name: org.matrix.rustcomponents:crypto-android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Update strings.xml to fix the "see and managed addresses[…]" typo.
Remove dependency on libolm
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
867363 | Triggered | Generic Password | 5908cd5 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/crypto/keysbackup/KeysBackupPasswordTest.kt | View secret |
867363 | Triggered | Generic Password | ac01523 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/crypto/keysbackup/KeysBackupPasswordTest.kt | View secret |
867363 | Triggered | Generic Password | 9a4602b | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/crypto/keysbackup/KeysBackupPasswordTest.kt | View secret |
867363 | Triggered | Generic Password | c8ab88b | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/crypto/keysbackup/KeysBackupPasswordTest.kt | View secret |
13948537 | Triggered | Generic High Entropy Secret | 9585262 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/session/contentscanner/ScanEncryptorUtilsTest.kt | View secret |
13948537 | Triggered | Generic High Entropy Secret | 797a4f9 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/session/contentscanner/ScanEncryptorUtilsTest.kt | View secret |
13948537 | Triggered | Generic High Entropy Secret | 6a8e978 | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/session/contentscanner/ScanEncryptorUtilsTest.kt | View secret |
13948537 | Triggered | Generic High Entropy Secret | 9a4602b | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/session/contentscanner/ScanEncryptorUtilsTest.kt | View secret |
13948537 | Triggered | Generic High Entropy Secret | c8ab88b | matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/internal/session/contentscanner/ScanEncryptorUtilsTest.kt | View secret |
🛠 Guidelines to remediate hardcoded secrets
-
Revoke and rotate the secret.
-
If possible, rewrite git history with
git commit --amend
andgit push --force
.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
0724f27
to
fc3943b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le rebase est ok.
Le code de migration me semble ok.
Un changelog STP.
TODO :
- mettre en place un waiting screen durant la migration.
- que se passe-t-il si la migration échoue ?
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist