Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1089 mettre en place le nouveau flow sso #1094

Merged
merged 28 commits into from
Oct 7, 2024

Conversation

NicolasBuquet
Copy link
Contributor

@NicolasBuquet NicolasBuquet commented Sep 25, 2024

Fix #1089

La création de compte fonctionne aussi peut-être en faisant un login ProConnect et en renseignant et activant un nouveau compte ProConnect. A tester.

Simulator Screenshot - iPhone 15 - 2024-09-25 at 18 34 38
Simulator Screenshot - iPhone 15 - 2024-09-25 at 18 35 02

@NicolasBuquet NicolasBuquet linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

gitguardian bot commented Oct 2, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13361669 Triggered Generic High Entropy Secret 1d6502e RiotNSE/BuildSettings.swift View secret
13361669 Triggered Generic High Entropy Secret 1d6502e RiotShareExtension/BuildSettings.swift View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

DevTchap/Config/BuildSettings.swift Show resolved Hide resolved
Tchap/Generated/Storyboards.swift Show resolved Hide resolved
RiotNSE/BuildSettings.swift Outdated Show resolved Hide resolved
RiotNSE/Common.xcconfig Outdated Show resolved Hide resolved
RiotNSE/Common.xcconfig Outdated Show resolved Hide resolved
RiotShareExtension/BuildSettings.swift Outdated Show resolved Hide resolved
@yostyle
Copy link
Contributor

yostyle commented Oct 4, 2024

Sur cette image create account n'est pas traduit. c'est toujours le cas ?

Simulator Screenshot - iPhone 15 - 2024-09-25 at 18 34 38

@NicolasBuquet
Copy link
Contributor Author

NicolasBuquet commented Oct 7, 2024

Sur cette image create account n'est pas traduit. c'est toujours le cas ?

@yostyle
Oui, ça doit toujours être le cas. Bien vu.
Je vais le traduire.
Et idem pour "Forgot password" sur l'écran suivant.

A mais non, ça doit être parce que mon simulateur est en anglais. En fait, ce sont les strings FR qui sont pas dispo en EN ! 😆
-> Je confirme : c'est bien ça. Une fois le simulateur passé en FR, tout est affiché en FR.
Je ne passe pas de temps à supporter une version EN dans l'état actuel de Tchap Legacy.

@NicolasBuquet NicolasBuquet force-pushed the 1089-mettre-en-place-le-nouveau-flow-sso branch from 7f9ed78 to fd78a72 Compare October 7, 2024 16:07
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 1083-activer-la-connexion-sso to develop October 7, 2024 16:16
@NicolasBuquet NicolasBuquet merged commit 6060158 into develop Oct 7, 2024
1 of 5 checks passed
@NicolasBuquet NicolasBuquet deleted the 1089-mettre-en-place-le-nouveau-flow-sso branch October 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mettre en place le nouveau flow SSO
2 participants