1093 sso gérer correctement les confirmations dactions critiques #1095
Conversation
Riot/Modules/CrossSigning/Setup/CrossSigningSetupCoordinator.swift
Outdated
Show resolved
Hide resolved
| @@ -230,6 +230,11 @@ - (void)goBack | |||
| } | |||
| } | |||
|
|
|||
| // Tchap: give access to backButton to allow a 'Cancel' functionnality. | |||
There was a problem hiding this comment.
I need to understand this change
There was a problem hiding this comment.
@yostyle
It is to enable a cancel button in the SSO web pop-up view.
Actually, only a "Done" button is available, that try to validate the login and that will re-trigger the SSO pop-up if login is incorrect.
This change is to enable access to "back" button to be able to propose a "Cancel" button that will not re-send the original request.
Utilisé ici :
NicolasBuquet
force-pushed
the
1093-sso-gérer-correctement-les-confirmations-dactions-critiques
branch
from
1144af1
to
fbb79f7
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
NicolasBuquet
force-pushed
the
1093-sso-gérer-correctement-les-confirmations-dactions-critiques
branch
from
363d65f
to
fbb79f7
Compare
NicolasBuquet
merged commit d9b0fd7
into
1089-mettre-en-place-le-nouveau-flow-sso
NicolasBuquet
force-pushed
the
1089-mettre-en-place-le-nouveau-flow-sso
branch
from
7f9ed78
to
fd78a72
Compare
NicolasBuquet
deleted the
1093-sso-gérer-correctement-les-confirmations-dactions-critiques
branch
Fix #1093
Tests effectués en login SSO sur :