Use GitHub pages hosted CSS file (Update to last PR) #40
Conversation
…e instead of the relative path to the css file)
…c run anyway) and the setup code section in its corresponding template
|
In addition, I think we should also update the index.html file in /root (not the one under docs/), there are a ton of rforge links Also then let me know the email link you would like me to replace here The other thing I wanted to mention was that the latest Git commit (17 Jun) was only updated for docs/index.html and not for the html files under different plot-type sub-directories within docs/ after the dldoc run |
…ad of rforge links)
|
@tdhock Are the link changes okay? (I just avoided the use of all rforge links) |
|
email link http://tdhock.github.io/ please |
|
please tell me if/when you want review or merge. |
Done
Please review/merge! |
|
@tdhock Hi, please merge this if it is okay, as I'll be pushing some test commits to the gh-pages branch (and I wouldn't want them to be included under this PR), also after that I'll be wrapping #38 soon and we can merge that and #41 into master (changes will be brought to gh-pages) Also, could you please decide on the thumbnail image to display on https://exts.ggplot2.tidyverse.org/gallery/ for directlabels? (the readme specifies 350x300, but it can be of different sizes ideally, as observed from the png dimensions in https://github.com/ggplot2-exts/gallery/tree/gh-pages/images) |
|
great, can you please make a thumbnail image? maybe draw it yourself or take it from one of the examples? |
Sure, but I think it would be best if you decide on the one to be displayed. I'll create an issue with preferable options from your examples now |
After #39 was pushed, I ran dldoc locally, pushed the changes to my gh-pages branch (those commits are reverted now) and checked to see if the stylesheet was getting linked - was fine for everything under the different plot type directories but for docs/index.html it apparently became
../../../estilo1.cssfrom../estilo1.css: (thanks to the update from templates/head.html)Sorry for not taking this into account, and also for the directlabels setup code that I updated in docs/index.html but not the same in its template earlier! (I should have made these back in the last PR itself)
I've fixed these, and for the link to the stylesheet, I'm using the css file hosted onto your GitHub pages (could also use cdn links as an alternative, but note that a normal GitHub link or raw.githubusercontent.com links to the file won't work)