Leanify package, add resamplings to dictionary #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR:
leanify
ing a package moves the code of the methods into themlr3resampling
namespace. The methods of the R6 instances then just call into these functions. In the past we often had problems with very large object sizes and this mitigates this.mlr3::mlr_resamplings
dictionary. This allows to construct resamplings usingrsmp("<resampling-id>")
, which we recommend over theResampling$new()
syntaxtask$data()