Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leanify package, add resamplings to dictionary #13

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

sebffischer
Copy link
Contributor

Summary of the PR:

  • leanifying a package moves the code of the methods into the mlr3resampling namespace. The methods of the R6 instances then just call into these functions. In the past we often had problems with very large object sizes and this mitigates this.
  • the resamplings are added to the mlr3::mlr_resamplings dictionary. This allows to construct resamplings using rsmp("<resampling-id>"), which we recommend over the Resampling$new() syntax
  • removed one unnecessary call to task$data()

@tdhock
Copy link
Owner

tdhock commented May 14, 2024

hi thanks for the PR
can you please add package:: prefix to leanify_package() to make it clear what pacakge it comes from? (I don't know where, is it mlr3?)

R/zzz.R Outdated Show resolved Hide resolved
@tdhock tdhock merged commit d1181f9 into tdhock:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants