Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train strata counts #7

Merged
merged 4 commits into from
Jan 23, 2024
Merged

train strata counts #7

merged 4 commits into from
Jan 23, 2024

Conversation

tdhock
Copy link
Owner

@tdhock tdhock commented Jan 21, 2024

Closes #5

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (119a8f6) 82.32% compared to head (9941c2b) 83.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   82.32%   83.56%   +1.24%     
==========================================
  Files           4        4              
  Lines         198      213      +15     
==========================================
+ Hits          163      178      +15     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdhock
Copy link
Owner Author

tdhock commented Jan 23, 2024

before merging need to proof-read vignettes.

@tdhock
Copy link
Owner Author

tdhock commented Jan 23, 2024

vignette for variable train size classification (has stratum) looks good

@tdhock tdhock merged commit b5a0619 into main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VariableSizeTrain enhanced strata support
2 participants