Add radar_sync.py script. #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simleo
reviewed
Mar 20, 2019
| self._client = paramiko.SSHClient() | ||
| self._root_dir = root_dir | ||
|
|
||
| def list_folder(self, year='', month='', day=''): |
There was a problem hiding this comment.
This method has a lot in common with the next one. Perhaps they can be refactored to call a common __exec_command method that does the repetitive job
| _folder = '{}/{}/{}/{}'.format(self._root_dir, year, month, day) | ||
|
|
||
| _, stdout, _ = self._client.exec_command('ls {}'.format(_folder)) | ||
| _contents = [] |
There was a problem hiding this comment.
This needs to be moved out of the try block, or exception will also trigger an UnboundLocalError: local variable '_contents' referenced before assignment
| key_filename=self._key_file | ||
| ) | ||
|
|
||
| _folder = '{}/{}/{}/{}'.format(self._root_dir, year, month, day) |
There was a problem hiding this comment.
This is a job for os.path.join
| _transport.close() | ||
|
|
||
|
|
||
| def check_hdfs_url(hdfs_url): |
There was a problem hiding this comment.
This is not necessary and potentially harmful. Better let the user's path through and let Pydoop / Hadoop handle it
| if not args.dryrun: | ||
| copy_to_hdfs(_local_path, _hdfs_path) | ||
|
|
||
| delete_local_folder(_local_path, args.dryrun) |
There was a problem hiding this comment.
Looks like we can just use shutil.rmtree here, and get rid of delete_local_folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.