Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image sync fields to schema #204

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add image sync fields to schema #204

merged 1 commit into from
Jul 17, 2024

Conversation

enolfc
Copy link
Collaborator

@enolfc enolfc commented Jul 17, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Added new fields for image synchronisation (see EGI-Federation/fedcloud-catchall-operations#350)

tdviet
tdviet reviewed Jul 17, 2024
View reviewed changes
Copy link
Owner

@tdviet tdviet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Enol, do you plan to have the list of images as a part of site configuration? For what purpose?

@enolfc
Copy link
Collaborator Author

enolfc commented Jul 17, 2024

Not the list of images, but whether to configure image synchronisation or not in the catchall instance.

@enolfc
Copy link
Collaborator Author

enolfc commented Jul 17, 2024

See sample config https://github.com/EGI-Federation/fedcloud-catchall-operations/blob/5f01874961fb46a5f98e4cb4946fa3422718f560/sites/WALTON-CLOUD.yaml

tdviet
tdviet approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@tdviet tdviet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdviet tdviet merged commit 97c78db into tdviet:master Jul 17, 2024
4 checks passed
@enolfc enolfc deleted the image-sync-schema branch July 17, 2024 14:44
@sebastian-luna-valero sebastian-luna-valero mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdviet tdviet tdviet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enolfc @tdviet