feat: ensure not null fields stay required in form view and can’t be removed #2061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces protection for required fields in form views that don't have default values. These "protected fields" must remain visible in form views and cannot be removed, ensuring data integrity by preventing forms from being submitted without values for required fields that lack defaults.
Key Changes:
- Added logic to identify "protected fields" (required fields without default values)
- Prevented removal of protected fields from form views in the UI
- Enhanced backend to automatically set protected fields as visible when creating/updating form views
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
apps/nextjs-app/src/features/app/blocks/view/form/util.ts |
Added isProtectedField utility function to identify required fields without defaults |
apps/nextjs-app/src/features/app/blocks/view/form/components/FormFieldEditor.tsx |
Updated UI to show tooltip and disable removal for protected fields |
apps/nextjs-app/src/features/app/blocks/view/form/components/FormField.tsx |
Updated required field logic to use isProtectedField helper |
apps/nextjs-app/src/features/app/blocks/view/form/components/FormEditor.tsx |
Prevented drag-to-remove operations for protected fields |
apps/nextjs-app/src/features/app/blocks/view/form/components/FromBody.tsx |
Added whitespace handling for form descriptions |
apps/nestjs-backend/src/features/view/view.service.ts |
Added logic to enforce visibility for protected fields when creating form views |
apps/nestjs-backend/src/features/field/field-calculate/field-view-sync.service.ts |
Added logic to enforce visibility when converting fields to protected status |
apps/nestjs-backend/test/view.e2e-spec.ts |
Added test for protected field visibility in new form views |
apps/nestjs-backend/test/field-view-sync.e2e-spec.ts |
Added test for protected field visibility when updating fields |
packages/common-i18n/src/locales/*/table.json |
Added translations for protectedFieldTip message across 10 locales |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nextjs-app/src/features/app/blocks/view/form/components/FormEditor.tsx
Outdated
Show resolved
Hide resolved
apps/nestjs-backend/src/features/field/field-calculate/field-view-sync.service.ts
Show resolved
Hide resolved
🧹 Preview Environment Cleanup
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.